[libcxx-commits] [PATCH] D59029: [libc++] Do not specify the underlying type of memory_order

[Louis Dionne via Phabricator via libcxx-commits]

ldionne added a comment.

In D59029#1419974 <https://reviews.llvm.org/D59029#1419974>, @mclow.lists wrote:

> In D59029#1419972 <https://reviews.llvm.org/D59029#1419972>, @zoecarver wrote:
>
> > Seems good to me. I remember @EricWF saying
> >
> > > And we should static assert the underlying type of this matches the type we declare in C++17.
> >
> > and
> >
> > > I would like to see an explicit underlying type declared here.
> >
> > though. He might have a point.
>
>
> I don't see how to do both. - match the C++17 size (which can change), and be explicit.
>
> I liked the `static_assert` that we had before - it found us a bug:  https://bugs.llvm.org/show_bug.cgi?id=40977


Well, it found that we had introduced a bug with that revision -- now there's nothing to `static_assert` anymore, since we're not saying anything about the underlying type. It's entirely possible that @EricWF had something else in mind -- if so, he can comment here and I can change the code again.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59029/new/

https://reviews.llvm.org/D59029