[libcxx-commits] [PATCH] D58945: Fix ABI compatibility of `<stdexcept>` with VCRuntime.
Louis Dionne via Phabricator via libcxx-commits
libcxx-commits at lists.llvm.org
Tue Mar 5 06:44:36 PST 2019
ldionne added a comment.
Do we have a tester that uses vcruntime?
================
Comment at: include/stdexcept:96
+public:
+ explicit logic_error(const _VSTD::string&); // Symbol uses versioned std::string
+ _LIBCPP_INLINE_VISIBILITY explicit logic_error(const char* __s) : exception(__s) {}
----------------
Ah, so libc++ is using `std::string`, and vcruntime is using `std::__1::string`? But libc++ only defines `basic_string` in namespace `__1`, so aren't both actually referring to `std::__1::string`? I'm a bit confused.
================
Comment at: src/support/runtime/stdexcept_default.ipp:37
+{
+__imp_ = le.__imp_;
+return *this;
----------------
Indentation.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D58945/new/
https://reviews.llvm.org/D58945
More information about the libcxx-commits
mailing list