[libcxx-commits] [PATCH] D58852: Changes from integrating PSTL with libstdc++

Tue Mar 5 06:44:21 PST 2019

rodgert marked an inline comment as done.
rodgert added a comment.

In D58852#1418265 <https://reviews.llvm.org/D58852#1418265>, @MikeDvorskiy wrote:

> >   pstl_config.h is not required
>
> Thomas, could you please clarify it?
>
> The fact is the file contains significant macros, which  are used in simd bricks, and the other useful macros.

The fact is, it is already included by another file here, so this include is redundant. Removing the include here is the correct thing to do, also because this config file's contents become part of the standard library's configuration when included in libstdc++ (and almost certainly the same with libc++).

================
Comment at: include/pstl/internal/algorithm_fwd.h:2
+// -*- C++ -*-
+//===-- algorithm_fwd.h --------------------------------------------------===//
+//
----------------
MikeDvorskiy wrote:
> Thomas, what's a reason to rename the files with forward declarations? (glue_algorithm_defs.h, glue_numeric_defs.h, glue_memory_defs.h to  algorithm_fwd.h, numeric_fwd.h, memory_fwd.h)
> 
Look carefully at the files, they are *NOT* the same thing.

Repository:
  rPSTL pstl

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58852/new/

https://reviews.llvm.org/D58852