[libcxx-commits] [PATCH] D58201: Make std::memory_order an enum class (P0439R0)

[Louis Dionne via Phabricator via libcxx-commits]

ldionne accepted this revision.
ldionne added a comment.

I made the changes I commented on when applying the diff. Thanks for the patch!



================
Comment at: include/atomic:613
+
+static_assert(_VSTD::is_same<typename _VSTD::underlying_type<memory_order>::type,
+			  unsigned>::value, "Underlying type differs from unsigned unexpectedly");
----------------
`typename` is not needed here, this is not a dependent context.


================
Comment at: include/atomic:618
+
+using __memory_order_underlying_t = _VSTD::underlying_type<memory_order>::type; // unsigned
+
----------------
Should use a typedef instead of a using statement because we had the brilliant idea to try and support C++03 in `<atomic>`.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58201/new/

https://reviews.llvm.org/D58201