[libcxx-commits] [PATCH] D63230: Add observer_ptr

Zoe Carver via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Sun Jun 30 12:35:03 PDT 2019


zoecarver updated this revision to Diff 207231.
zoecarver marked 2 inline comments as done.
zoecarver added a comment.

- updated based on your comments
- added a few constexpr tests

My main question with adding `constexpr` is in `swap`. I am not sure how to make a `swap` function that is `constexpr`.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D63230/new/

https://reviews.llvm.org/D63230

Files:
  include/CMakeLists.txt
  include/experimental/memory
  include/module.modulemap
  test/libcxx/double_include.sh.cpp
  test/libcxx/experimental/memory/memory.observer.ptr/version.pass.cpp
  test/std/experimental/memory/memory.observer.ptr/conv.pass.cpp
  test/std/experimental/memory/memory.observer.ptr/ctor.pass.cpp
  test/std/experimental/memory/memory.observer.ptr/hash.pass.cpp
  test/std/experimental/memory/memory.observer.ptr/mod/release.pass.cpp
  test/std/experimental/memory/memory.observer.ptr/mod/reset.pass.cpp
  test/std/experimental/memory/memory.observer.ptr/mod/swap.pass.cpp
  test/std/experimental/memory/memory.observer.ptr/obs.pass.cpp
  test/std/experimental/memory/memory.observer.ptr/spec.pass.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D63230.207231.patch
Type: text/x-patch
Size: 23304 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/libcxx-commits/attachments/20190630/1ca3496a/attachment-0001.bin>


More information about the libcxx-commits mailing list