[libcxx-commits] [PATCH] D62452: Regex backreference [2/3] Validate the entire regex is consumed.

[Mark de Wever via Phabricator via libcxx-commits]

Mordante marked an inline comment as done.
Mordante added a comment.

Thanks for the review!

I don't have commit access, could you commit this patch?



================
Comment at: libcxx/include/regex:969
+    __re_err_unknown,
+    // Not sure whether placing it before unknown is considered ABI breakage.
+    __re_err_parse
----------------
mclow.lists wrote:
> Sadly, I think that placing it before 'unknown' *is* an ABI break, because we throw these error codes, and if people were to catch them - and dispatch on them, their code would break.
I feared it would. Updated the patch to remove this comment


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62452/new/

https://reviews.llvm.org/D62452