[libcxx-commits] [PATCH] D62452: Regex backreference [2/3] Validate the entire regex is consumed.

[Marshall Clow via Phabricator via libcxx-commits]

mclow.lists accepted this revision.
mclow.lists added a comment.
This revision is now accepted and ready to land.

This looks good to me.



================
Comment at: libcxx/include/regex:969
+    __re_err_unknown,
+    // Not sure whether placing it before unknown is considered ABI breakage.
+    __re_err_parse
----------------
Sadly, I think that placing it before 'unknown' *is* an ABI break, because we throw these error codes, and if people were to catch them - and dispatch on them, their code would break.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62452/new/

https://reviews.llvm.org/D62452