[libcxx-commits] [PATCH] D63748: Pass std::unique_ptr, std::shared_ptr and std::weak_ptr in registers when possible.

[Eric Fiselier via Phabricator via libcxx-commits]

EricWF added inline comments.


================
Comment at: libcxx/include/__config:1017
 
+#if __has_cpp_attribute(clang::trivial_abi) && defined(_LIBCPP_ABI_UNSTABLE)
+#  define _LIBCPP_TRIVIAL_ABI [[clang::trivial_abi]]
----------------
I'm trying to keep all of the ABI configuration in the same place at the top of the file.

Could you give this a descriptive name like `_LIBCPP_ABI_ENABLE_TRIVIAL_ABI_ATTRIBUTE` and then use that here to configure `_LIBCPP_TRIVIAL_ABI`?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D63748/new/

https://reviews.llvm.org/D63748