[libcxx-commits] [PATCH] D63744: In the libc++ unstable ABI, use [[no_unique_address]] instead of __compressed_pair when available.

Mon Jun 24 16:59:55 PDT 2019

mclow.lists added a comment.

A couple of general comments; still working through all the bits.

================
Comment at: libcxx/include/__config:1013

+#if __has_cpp_attribute(no_unique_address) && defined(_LIBCPP_ABI_UNSTABLE)
+#  define _LIBCPP_USE_NO_UNIQUE_ADDRESS 1
----------------
This should really go with the rest of the ABI flags up around line #70, and let's give it an ABI name like `_LIBCPP_ABI_USE_NO_UNIQUE_ADDRESS`

================
Comment at: libcxx/include/__hash_table:3035

+#undef __first_node_
+#undef __size_
----------------
Shouldn't these be wrapped in a `#ifdef _LIBCPP_USE_NO_UNIQUE_ADDRESS` block?

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D63744/new/

https://reviews.llvm.org/D63744