[libcxx-commits] [PATCH] D59886: Heterogeneous lookup for unordered containers (P0919R3)

[Zoe Carver via Phabricator via libcxx-commits]

zoecarver marked 2 inline comments as done.
zoecarver added inline comments.


================
Comment at: test/std/containers/hetro_lookups.pass.cpp:1
+//===----------------------------------------------------------------------===//
+//
----------------
I will split this into four tests. 


================
Comment at: test/std/containers/key_equal.fail.cpp:27
+{
+    // expected-error {{type 'const custom_hash' does not provide a call operator}}
+    // expected-error {{static_assert failed due to requirement '__check_hash_requirements<int, custom_hash>::value' "the specified hash does not meet the Hash requirements"}}
----------------
mclow.lists wrote:
> zoecarver wrote:
> > These comments describe errors in other files. What line should they go on and how should they be formatted? 
> You just say `expected-error@<filename>:<line number>`  ; and you can use `*` for the line number (in fact, you should).
Will do.


Repository:
  rCXX libc++

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59886/new/

https://reviews.llvm.org/D59886