[libcxx-commits] [PATCH] D58587: Implement P0433: deduction guides for <map>

[Arthur O'Dwyer via Phabricator via libcxx-commits]

Quuxplusone updated this revision to Diff 205408.
Quuxplusone marked an inline comment as done.
Quuxplusone added a comment.

- Add an `__identity<T>::type` "firewall" on the comparator type as well as on the allocator type.

- Use `enable_if_t` and `remove_const_t` instead of the longer C++11-friendly names. I assume that since the deduction guides are compiled only in C++17 library mode, they are allowed to rely on C++14-and-later library features. However, I can put it back the way it was if someone disagrees with my assumption.


Repository:
  rCXX libc++

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58587/new/

https://reviews.llvm.org/D58587

Files:
  include/iterator
  include/map
  test/std/containers/associative/map/map.cons/deduct.fail.cpp
  test/std/containers/associative/map/map.cons/deduct.pass.cpp
  test/std/containers/associative/map/map.cons/deduct_const.pass.cpp
  test/std/containers/associative/multimap/multimap.cons/deduct.fail.cpp
  test/std/containers/associative/multimap/multimap.cons/deduct.pass.cpp
  test/std/containers/associative/multimap/multimap.cons/deduct_const.pass.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D58587.205408.patch
Type: text/x-patch
Size: 38085 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/libcxx-commits/attachments/20190618/2f9559f4/attachment-0001.bin>