[libcxx-commits] [PATCH] D62384: [libcxx][tests]Skip checking midpoint of adjacent values for PPC double-double

Hubert Tong via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Tue Jun 18 14:20:59 PDT 2019


hubert.reinterpretcast accepted this revision.
hubert.reinterpretcast added a comment.

I believe that all comments have been addressed. LGTM.



================
Comment at: libcxx/test/std/numerics/numeric.ops/numeric.ops.midpoint/midpoint.float.pass.cpp:84
 
-//  Since there's nothing in between, the midpoint has to be one or the other
-    T res;
-    res = std::midpoint(d0, d1);
-    assert(res == d0 || res == d1);
-    assert(d0 <= res);
-    assert(res <= d1);
-    res = std::midpoint(d1, d0);
-    assert(res == d0 || res == d1);
-    assert(d0 <= res);
-    assert(res <= d1);
-
-    res = std::midpoint(d1, d2);
-    assert(res == d1 || res == d2);
-    assert(d1 <= res);
-    assert(res <= d2);
-    res = std::midpoint(d2, d1);
-    assert(res == d1 || res == d2);
-    assert(d1 <= res);
-    assert(res <= d2);
+#if defined(__PPC__) && __LONG_DOUBLE_128__ && !__LONG_DOUBLE_IEEE128__
+    // For 128 bit long double implemented as 2 doubles on PowerPC,
----------------
Just a note: It appears AIX does not provide `nextafterl` for such long doubles anyway.


Repository:
  rCXX libc++

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62384/new/

https://reviews.llvm.org/D62384





More information about the libcxx-commits mailing list