[libcxx-commits] [PATCH] D58590: Implement P0433: deduction guides for <unordered_map>

[Arthur O'Dwyer via Phabricator via libcxx-commits]

Quuxplusone updated this revision to Diff 204822.
Quuxplusone added a comment.

Review comments; remove unnecessary `_VSTD::` before `remove_const`; consistent use of typedefs `P` and `PC` to match the corresponding `unordered_map` tests from D58587 <https://reviews.llvm.org/D58587>.

@mclow.lists: I //think// this one is ready to land, as well as D58617 <https://reviews.llvm.org/D58617>, although they probably deserve some close scrutiny to make sure the tests are testing the things they should be testing.

I wonder if I should switch from using `typename remove_const<T>::type` to `remove_const_t<T>`, since all the deduction guides are compiled only in C++17 mode anyway. If we want to do that, I propose to do it as a separate patch, or at least shortly thereafter to submit a separate patch to consistently use `remove_const_t` in the `<set>` and `<map>` deduction guides.


Repository:
  rCXX libc++

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58590/new/

https://reviews.llvm.org/D58590

Files:
  include/unordered_map
  test/std/containers/unord/unord.map/unord.map.cnstr/deduct.fail.cpp
  test/std/containers/unord/unord.map/unord.map.cnstr/deduct.pass.cpp
  test/std/containers/unord/unord.map/unord.map.cnstr/deduct_const.pass.cpp
  test/std/containers/unord/unord.multimap/unord.multimap.cnstr/deduct.fail.cpp
  test/std/containers/unord/unord.multimap/unord.multimap.cnstr/deduct.pass.cpp
  test/std/containers/unord/unord.multimap/unord.multimap.cnstr/deduct_const.pass.cpp
  www/cxx2a_status.html

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D58590.204822.patch
Type: text/x-patch
Size: 63165 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/libcxx-commits/attachments/20190614/7ee046fa/attachment-0001.bin>