[libcxx-commits] [PATCH] D63328: [libc++] Avoid using timespec when it might not be available

Mikhail Maltsev via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Tue Jun 18 02:43:41 PDT 2019


miyuki added a comment.

`__libcpp_condvar_timedwait` needs to be implemented in a different TU, so it can't be a template and at the same time it needs some sort of time point. I think `timespec` was chosen because it is what `pthread_cond_timedwait` expects. Do you think a specialization of `chrono::time_point` (like `chrono::time_point<chrono::system_clock, chrono::nanoseconds>` used by `condition_variable::__do_timed_wait`) would make more sense here?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D63328/new/

https://reviews.llvm.org/D63328





More information about the libcxx-commits mailing list