[libcxx-commits] [PATCH] D63345: [libcxxabi] Use an explicit list to export symbols from the dylib

[Louis Dionne via Phabricator via libcxx-commits]

ldionne added a comment.

In D63345#1543880 <https://reviews.llvm.org/D63345#1543880>, @thakis wrote:

> add_llvm_symbol_exports  in the LLVM CMake files have a cross-platform way of doing export files: http://llvm-cs.pcc.me.uk/cmake/modules/AddLLVM.cmake#71
>
> It compiles to exported_symbols_list on mac, creates a linker script on posix, and creates a def file on Windows.


Interesting, thanks for the heads up. It looks like it supports multiple calls with different export lists for the same target, too, right?

However, we'd have to either drop support for the standalone libc++ build or copy the function to libc++'s CMake modules. @EricWF Does this seem okay until we're fully on the monorepo and the standalone libc++ build is no more?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D63345/new/

https://reviews.llvm.org/D63345