[libcxx-commits] [PATCH] D63063: Bug 42208: speeding up std::merge

[Eric Fiselier via libcxx-commits]

Woops, I meant to say:

Binary size isn't the only factor. I'm not too concerned about an increase
in size here if the performance increase pulls the weight.

On Fri., Jun. 14, 2019, 1:00 a.m. Eric Fiselier via Phabricator, <
reviews at reviews.llvm.org> wrote:

> EricWF added a comment.
>
> Binary size isn't
>
>
>
> ================
> Comment at: benchmarks/algorithms.merge.bench.cpp:1
> +#include <array>
> +#include <string>
> ----------------
> Missing license header.
>
>
> ================
> Comment at: benchmarks/algorithms.merge.bench.cpp:87
> +    auto Data = TestType::generateInput(Quantity);
> +    using VecT = decltype(Data);
> +
> ----------------
> I know this doesn't affect the timing (or shouldn't), but it's useful to
> split out the prologue of a benchmark so it's easier to inspect the
> assembly the loop generates.
>
> Also, if you could provide some snippits or analysis about what changed in
> the assembly that's giving the performance win.
>
>
> CHANGES SINCE LAST ACTION
>   https://reviews.llvm.org/D63063/new/
>
> https://reviews.llvm.org/D63063
>
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/libcxx-commits/attachments/20190614/2c5a55ab/attachment.html>