[libcxx-commits] [PATCH] D63296: [libc++] Fix build with gcc 4.8

[Nico Weber via Phabricator via libcxx-commits]

thakis added a comment.

Are libc++'s supported compilers different from LLVM's? 4.8 is still supported for LLVM (but not for long).

Chromium itself doesn't use gcc at all, but some diaspora projects (e.g. v8, for node) support building with gcc, so we have a bot that builds a "hello world" to make sure that the build config bits to disable clang keep working. Maybe that file should just not include a C++ header but only a C header, or maybe we shouldn't use hermetic libc++ on that bot.

In any case, if this is the only required change, there's little harm in accepting it, no? It solves a problem for us (that we could possibly solve in a different way) and the patch arguably makes the code easier to read too :)


Repository:
  rCXX libc++

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D63296/new/

https://reviews.llvm.org/D63296