[libcxx-commits] [PATCH] D63050: Test that correct value category is used in scoped_allocator_adaptor::construct

Zoe Carver via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Sat Jun 8 13:56:03 PDT 2019


zoecarver added a comment.

It doesn't compile because `Alloc1` is convertible to `Alloc2`, and when it makes the conversion it can turn into either value category (thanks to Eric for explaining <https://godbolt.org/z/YKfRH8>). Anyhow, given that bit of information I do not see how the pair portion of this issue can be tested (or how the change matters for pairs).


Repository:
  rCXX libc++

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D63050/new/

https://reviews.llvm.org/D63050





More information about the libcxx-commits mailing list