[libcxx-commits] [PATCH] D63047: [libc++] Fix leading zeros in std::to_chars

[Zoe Carver via Phabricator via libcxx-commits]

zoecarver added a comment.

In D63047#1535306 <https://reviews.llvm.org/D63047#1535306>, @ivafanas wrote:

> In D63047#1535297 <https://reviews.llvm.org/D63047#1535297>, @zoecarver wrote:
>
> > The example in the bug doesn't work: `std::to_chars(buf, buf + 100, (unsigned long)0xffffffff)`.
> >
> > Edit: it outputs `0004294967295`.
>
>
> Hi,
>
> Hmm, are you sure?
>  I've just tested fixed version of `std::to_chars` and `std::to_chars(buf, buf + 100, (unsigned long)0xffffffff)` produces `4294967295` as expected.
>
> May be you didn't recompile implementation before run lit tests?


Yep, you're right. I applied the patch but forgot to recompile. Sorry for the false alarm. This patch looks good to me :)


Repository:
  rCXX libc++

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D63047/new/

https://reviews.llvm.org/D63047