[libcxx-commits] [PATCH] D58879: Implement uses-allocator (P0591R4)

[Zoe Carver via Phabricator via libcxx-commits]

zoecarver marked an inline comment as done.
zoecarver added inline comments.


================
Comment at: test/std/experimental/memory/memory.polymorphic.allocator.class/memory.polymorphic.allocator.mem/construct_pair_const_lvalue_pair.pass.cpp:122
 {
+#if _LIBCPP_STD_VER <= 17
     using ERT = std::experimental::erased_type;
----------------
zoecarver wrote:
> zoecarver wrote:
> > I really don't like disabling tests, but I think that these tests are incorrect (at least for c++20). Uses-allocator construction requires that types (or pair types) implement a uses-allocator typedef that is //the same// as the allocator they are being passed. This means that when these tests are passed the wrong allocator type, they choose the incorrect (well... actually it is correct) overload ([[ http://eel.is/c++draft/allocator.uses.construction#5.1 | the first one ]]). If I am mistaken about this, let me know, and I will change the uses-allocator implementation. 
> I think [[ https://cplusplus.github.io/LWG/issue2975 | 2975 ]] might fix this actually. 
This is an experimental library! The patch should not touch it. 


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58879/new/

https://reviews.llvm.org/D58879