[libcxx-commits] [PATCH] D62719: A hot fix for exclusive_scan

Thomas Rodgers via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Wed Jun 5 13:39:39 PDT 2019


rodgert added a comment.

In D62719#1525469 <https://reviews.llvm.org/D62719#1525469>, @mclow.lists wrote:

> In D62719#1525450 <https://reviews.llvm.org/D62719#1525450>, @rodgert wrote:
>
> > Actually, we should probably get a test of some sort here before accepting the change. Yes, it's fairly obviously wrong and the fix is fairly obviously correct, but it's a regression and we should provide tests for regressions, lest certain standard library maintainers ask uncomfortable questions.
>
>
> My ears are suddenly burning ;-)
>  Are people talking about me?


Hah, I didn't have you in mind specifically, but rather that other standard library maintainer that asked me about it.


Repository:
  rPSTL pstl

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62719/new/

https://reviews.llvm.org/D62719





More information about the libcxx-commits mailing list