[libcxx-commits] [PATCH] D62816: [libcxx] Add test to check min/max requirement to regular expression.

[Louis Dionne via Phabricator via libcxx-commits]

This revision was automatically updated to reflect the committed changes.
Closed by commit rL362525: [libcxx] Add test to check min/max requirement to regular expression (authored by ldionne, committed by ).
Herald added subscribers: llvm-commits, christof.
Herald added a project: LLVM.

Changed prior to commit:
  https://reviews.llvm.org/D62816?vs=202737&id=202964#toc

Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62816/new/

https://reviews.llvm.org/D62816

Files:
  libcxx/trunk/test/std/re/re.grammar/excessive_brace_min_max.pass.cpp


Index: libcxx/trunk/test/std/re/re.grammar/excessive_brace_min_max.pass.cpp
===================================================================
--- libcxx/trunk/test/std/re/re.grammar/excessive_brace_min_max.pass.cpp
+++ libcxx/trunk/test/std/re/re.grammar/excessive_brace_min_max.pass.cpp
@@ -0,0 +1,67 @@
+//===----------------------------------------------------------------------===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
+//
+//===----------------------------------------------------------------------===//
+
+// <regex>
+// UNSUPPORTED: libcpp-no-exceptions
+// UNSUPPORTED: c++98, c++03
+
+// the "n" and "m" in `a{n,m}` should be within the numeric limits.
+// requirement "m >= n" should be checked.
+
+#include <regex>
+#include <cassert>
+#include "test_macros.h"
+
+int main(int, char**) {
+  // test that `n <= m`
+  for (std::regex_constants::syntax_option_type op :
+       {std::regex::basic}) {
+    try {
+      TEST_IGNORE_NODISCARD std::regex("a\\{3,2\\}", op);
+      assert(false);
+    } catch (const std::regex_error &e) {
+      assert(e.code() == std::regex_constants::error_badbrace);
+      LIBCPP_ASSERT(e.code() == std::regex_constants::error_badbrace);
+    }
+  }
+  for (std::regex_constants::syntax_option_type op :
+       {std::regex::ECMAScript, std::regex::extended, std::regex::egrep,
+        std::regex::awk}) {
+    try {
+      TEST_IGNORE_NODISCARD std::regex("a{3,2}", op);
+      assert(false);
+    } catch (const std::regex_error &e) {
+      assert(e.code() == std::regex_constants::error_badbrace);
+      LIBCPP_ASSERT(e.code() == std::regex_constants::error_badbrace);
+    }
+  }
+
+  // test that both bounds are within the limit
+  for (std::regex_constants::syntax_option_type op :
+       {std::regex::basic}) {
+    try {
+      TEST_IGNORE_NODISCARD std::regex("a\\{100000000000000000000,10000000000000000000\\}", op);
+      assert(false);
+    } catch (const std::regex_error &e) {
+      assert(e.code() == std::regex_constants::error_badbrace);
+      LIBCPP_ASSERT(e.code() == std::regex_constants::error_badbrace);
+    }
+  }
+  for (std::regex_constants::syntax_option_type op :
+       {std::regex::ECMAScript, std::regex::extended, std::regex::egrep,
+        std::regex::awk}) {
+    try {
+      TEST_IGNORE_NODISCARD std::regex("a{100000000000000000000,10000000000000000000}", op);
+      assert(false);
+    } catch (const std::regex_error &e) {
+      assert(e.code() == std::regex_constants::error_badbrace);
+      LIBCPP_ASSERT(e.code() == std::regex_constants::error_badbrace);
+    }
+  }
+  return 0;
+}


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D62816.202964.patch
Type: text/x-patch
Size: 2755 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/libcxx-commits/attachments/20190604/e599714d/attachment.bin>