[libcxx-commits] [PATCH] D62816: [libcxx] Add test to check min/max requirement to regular expression.

[Louis Dionne via Phabricator via libcxx-commits]

ldionne added a comment.

In D62816#1528506 <https://reviews.llvm.org/D62816#1528506>, @amakc11 wrote:

> I don't understand the request. Please, clarify. Also, it would help if you use the terms from the comments in the suggested test.


I want to test that `n <= m` and that `n <= LIMIT` separately:

  // the "n" and "m" in `a{n,m}` should be within the numeric limits.
  // requirement "m >= n" should be checked.
  
  #include <regex>
  #include <cassert>
  #include "test_macros.h"
  
  int main(int, char**) {
    // test that `n <= m`
    for (std::regex_constants::syntax_option_type op :
         {std::regex::basic}) {
      try {
        TEST_IGNORE_NODISCARD std::regex("a\\{3,2\\}", op);
        assert(false);
      } catch (const std::regex_error &e) {
        assert(e.code() == std::regex_constants::error_badbrace);
        LIBCPP_ASSERT(e.code() == std::regex_constants::error_badbrace);
      }
    }
    for (std::regex_constants::syntax_option_type op :
         {std::regex::ECMAScript, std::regex::extended, std::regex::egrep,
          std::regex::awk}) {
      try {
        TEST_IGNORE_NODISCARD std::regex("a{3,2}", op);
        assert(false);
      } catch (const std::regex_error &e) {
        assert(e.code() == std::regex_constants::error_badbrace);
        LIBCPP_ASSERT(e.code() == std::regex_constants::error_badbrace);
      }
    }
  
    // test that both bounds are within the limit
    for (std::regex_constants::syntax_option_type op :
         {std::regex::basic}) {
      try {
        TEST_IGNORE_NODISCARD std::regex("a\\{100000000000000000000,10000000000000000002\\}", op);
        assert(false);
      } catch (const std::regex_error &e) {
        assert(e.code() == std::regex_constants::error_badbrace);
        LIBCPP_ASSERT(e.code() == std::regex_constants::error_badbrace);
      }
    }
    for (std::regex_constants::syntax_option_type op :
         {std::regex::ECMAScript, std::regex::extended, std::regex::egrep,
          std::regex::awk}) {
      try {
        TEST_IGNORE_NODISCARD std::regex("a{100000000000000000000,10000000000000000002}", op);
        assert(false);
      } catch (const std::regex_error &e) {
        assert(e.code() == std::regex_constants::error_badbrace);
        LIBCPP_ASSERT(e.code() == std::regex_constants::error_badbrace);
      }
    }
  
    return 0;
  }


Repository:
  rCXX libc++

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62816/new/

https://reviews.llvm.org/D62816