[libcxx-commits] [PATCH] D60027: Add shift functions (P0769)

Zoe Carver via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Sat Jul 27 12:31:30 PDT 2019


zoecarver updated this revision to Diff 212066.
zoecarver added a comment.
Herald added a subscriber: christof.

- valid constexpr
- much simpler implementation
- correct implementation (one that actually works)
- one implementation for all iterators (including forward iterators)
- tests that are more clear (correct on inspection)


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D60027/new/

https://reviews.llvm.org/D60027

Files:
  libcxx/include/algorithm
  libcxx/test/std/algorithms/alg.shift/shift_exec_policy.pass.cpp
  libcxx/test/std/algorithms/alg.shift/shift_left.pass.cpp
  libcxx/test/std/algorithms/alg.shift/shift_right.pass.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D60027.212066.patch
Type: text/x-patch
Size: 16889 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/libcxx-commits/attachments/20190727/b17676ec/attachment.bin>


More information about the libcxx-commits mailing list