[libcxx-commits] [PATCH] D65041: Change requirements on linear_congruential_engine

[Zoe Carver via Phabricator via libcxx-commits]

zoecarver marked an inline comment as done.
zoecarver added a comment.

I think it may be good to remove Schrage's algorithm altogether and file an LWG issue for the remaining edge cases. It is very slow and feels out of place in LCG.  Additionally, Schrage's algorithm introduces lot's of added complexity and space for bugs.



================
Comment at: libcxx/include/random:1677
+{
+    static_assert(__a != 0 || __m != 0 ||
+                  !_MightOverflow ||
----------------
This `static_assert` is redundant. Maybe I should remove it. 


Repository:
  rCXX libc++

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D65041/new/

https://reviews.llvm.org/D65041