[libcxx-commits] [PATCH] D64941: [libc++] Fix link error with _LIBCPP_HIDE_FROM_ABI_PER_TU and std::string

[Eric Fiselier via Phabricator via libcxx-commits]

EricWF added a comment.

This change isn't strictly correct. A lot of these constructors were externally instantiated before we made them templates. 
I suspect this will break the ABI.

We'll need to wrap these in `_LIBCPP_BUILDING_LIBRARY` to continue generating the old definitions.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D64941/new/

https://reviews.llvm.org/D64941