[libcxx-commits] [PATCH] D64299: Make ~mutex and ~condition_variable trivial with Bionic pthreads

Dmitry Vyukov via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Wed Jul 17 22:49:53 PDT 2019


dvyukov added a comment.

In D64299#1590752 <https://reviews.llvm.org/D64299#1590752>, @EricWF wrote:

> Thanks for bringing this up. Indeed this change really hurts TSAN.
>  I'll look for ways to work around this issue.
>
> I think we could have clang provide an annotation for mutex types that will inject calls to the tsan runtime when a mutex gets created or destroyed.
>
> On a separate note, what kinds of resources leaks are you imagining?


Memory.

> And where are these resources created?

When mutex is created or first locked.


Repository:
  rCXX libc++

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D64299/new/

https://reviews.llvm.org/D64299





More information about the libcxx-commits mailing list