[libcxx-commits] [PATCH] D64105: libc++: add _LIBCPP_HAS_NO_LONG_DOUBLE

[Dionna Amalie Glaze via Phabricator via libcxx-commits]

deeglaze abandoned this revision.
deeglaze marked 4 inline comments as done.
deeglaze added a comment.
Herald added a subscriber: wuzish.

After further experimentation in our toolchain, it is infeasible for us to avoid the long double maths functions. We will just have to supplement them.



================
Comment at: libcxx/include/cmath:445
 using ::nextafterf;
+#ifndef _LIBCXX_HAS_NO_LONG_DOUBLE
 using ::nexttoward;
----------------
mclow.lists wrote:
> These seem wrong to me. `nexttoward` takes a double, and `nexttowardf` takes a float.
> 
They both take 2 arguments, the second of which is a long double. Neither are defined in newlib if _LDBL_EQ_DBL is not defined.


================
Comment at: libcxx/include/locale:180
 
+#include <features.h>
 #include <__config>
----------------
mclow.lists wrote:
> Where did **this** come from?
Removed.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D64105/new/

https://reviews.llvm.org/D64105