[libcxx-commits] [PATCH] D64818: [libcxx] Construct path using a instance of std::locale

Arthur O'Dwyer via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Wed Jul 17 08:15:22 PDT 2019


Quuxplusone added inline comments.


================
Comment at: libcxx/include/filesystem:809
+  static wstring __convert(_Iter __i, const locale& __loc) {
+    const char __sentinel = char{};
+    string __s;
----------------
`char{}` is a strange way to spell `'\0'`, and since `sentinel` is used only on line 811, I think you don't need `sentinel` at all.


Repository:
  rCXX libc++

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D64818/new/

https://reviews.llvm.org/D64818





More information about the libcxx-commits mailing list