[libcxx-commits] [PATCH] D64299: Make ~mutex and ~condition_variable trivial with Bionic pthreads

[Elliott Hughes via Phabricator via libcxx-commits]

enh added a comment.

i assume the idea here is "all libc++ mutexes are covered by RAII anyway, so there's no value to the error checking"?

ah, i see https://reviews.llvm.org/rL365273 has more motivation.

i think main concern would be that this would make it harder to change the pthread mutex implementation at a later date, but that seems unrealistic anyway given our existing ABI constraints, and i don't think anyone would want to add an allocation in there anyway. if i knew how to add yabinc and eugenis i'd ask their opinions too, but so far this actually seems reasonable (and the "trivial destructor" motivation in the other CL is a stronger argument than the "optimization" i was expecting).

lgtm.


Repository:
  rCXX libc++

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D64299/new/

https://reviews.llvm.org/D64299