[libcxx-commits] [libcxx] r366025 - Harden variant test added in r366022

[Eric Fiselier via libcxx-commits]

Author: ericwf
Date: Sun Jul 14 11:30:34 2019
New Revision: 366025

URL: http://llvm.org/viewvc/llvm-project?rev=366025&view=rev
Log:
Harden variant test added in r366022

The test was brittle since it only went boom for one specific type, when
really it should go boom for all of them.

Modified:
    libcxx/trunk/test/std/utilities/variant/variant.variant/variant.ctor/T.pass.cpp

Modified: libcxx/trunk/test/std/utilities/variant/variant.variant/variant.ctor/T.pass.cpp
URL: http://llvm.org/viewvc/llvm-project/libcxx/trunk/test/std/utilities/variant/variant.variant/variant.ctor/T.pass.cpp?rev=366025&r1=366024&r2=366025&view=diff
==============================================================================
--- libcxx/trunk/test/std/utilities/variant/variant.variant/variant.ctor/T.pass.cpp (original)
+++ libcxx/trunk/test/std/utilities/variant/variant.variant/variant.ctor/T.pass.cpp Sun Jul 14 11:30:34 2019
@@ -177,13 +177,13 @@ void test_T_ctor_basic() {
 #endif
 }
 
-struct BoomOnInt {
+struct BoomOnAnything {
   template <class T>
-  constexpr BoomOnInt(T) { static_assert(!std::is_same<T, int>::value, ""); }
+  constexpr BoomOnAnything(T) { static_assert(!std::is_same<T, T>::value, ""); }
 };
 
 void test_no_narrowing_check_for_class_types() {
-  using V = std::variant<int, BoomOnInt>;
+  using V = std::variant<int, BoomOnAnything>;
   V v(42);
   assert(v.index() == 0);
   assert(std::get<0>(v) == 42);