[libcxx-commits] [PATCH] D58590: Implement P0433: deduction guides for <unordered_map>

Arthur O'Dwyer via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Sat Jul 13 08:58:37 PDT 2019


Quuxplusone updated this revision to Diff 209697.
Quuxplusone edited the summary of this revision.
Quuxplusone added a comment.

Use `_EnableIf` and `remove_const_t` instead of `enable_if` and `remove_const`.
Whitespace diffs.
Preemptively add XFAILs on apple-clang, matching the XFAILs that were needed for `unordered_set`.

@ldionne ping! I believe this is ready to land.

This completes my patch-series on the topic of "CTAD for associative and unordered containers."

Btw, I've verified that the container adaptors are all done (by Marshall, a while ago). The one place libc++ is known to be still missing deduction guides is `std::function` ( https://bugs.llvm.org/show_bug.cgi?id=39606 ).


Repository:
  rCXX libc++

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58590/new/

https://reviews.llvm.org/D58590

Files:
  include/unordered_map
  test/std/containers/unord/unord.map/unord.map.cnstr/deduct.fail.cpp
  test/std/containers/unord/unord.map/unord.map.cnstr/deduct.pass.cpp
  test/std/containers/unord/unord.map/unord.map.cnstr/deduct_const.pass.cpp
  test/std/containers/unord/unord.multimap/unord.multimap.cnstr/deduct.fail.cpp
  test/std/containers/unord/unord.multimap/unord.multimap.cnstr/deduct.pass.cpp
  test/std/containers/unord/unord.multimap/unord.multimap.cnstr/deduct_const.pass.cpp
  www/cxx2a_status.html

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D58590.209697.patch
Type: text/x-patch
Size: 62077 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/libcxx-commits/attachments/20190713/fe154d44/attachment-0001.bin>


More information about the libcxx-commits mailing list