[libcxx-commits] [PATCH] D64251: Don't depend on psutil on AIX

David Tenty via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Wed Jul 10 15:06:45 PDT 2019


daltenty added a comment.

In D64251#1577374 <https://reviews.llvm.org/D64251#1577374>, @davide wrote:

> This is adding a fair amount of complexity on something that just works fine on basically every platform but AIX.
>  If AIX has issue with `psutil`, maybe the fix should be submitted to `psutil` upstream instead of having this dance here?


I appreciate the concern, however in the original change which added timeout functionality to lit (review D14706 <https://reviews.llvm.org/D14706>), it was already noted that depending on psutil wasn't supposed to be permanent. Removing this external dependency from lit would be desirable and hopefully other platforms will follow suit in the future.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D64251/new/

https://reviews.llvm.org/D64251





More information about the libcxx-commits mailing list