[libcxx-commits] [PATCH] D64378: [libcxx] Use C11 thread API on Fuchsia

[Eric Fiselier via Phabricator via libcxx-commits]

EricWF added inline comments.


================
Comment at: libcxx/include/__config:1068
 #  if defined(__FreeBSD__) || \
-      defined(__Fuchsia__) || \
       defined(__wasi__) || \
----------------
Switching the implementation used by Fuchsia is ABI breaking. Are we 100% certain that all of our Fuchsia users don't expect ABI stability?


================
Comment at: libcxx/include/__config:1107
 #if (defined(_LIBCPP_HAS_THREAD_API_PTHREAD) && defined(__GLIBC__)) \
+  || defined(_LIBCPP_HAS_THREAD_API_FUCHSIA) \
   || defined(_LIBCPP_HAS_THREAD_API_WIN32)
----------------
Can you point towards the C11 source for `mtx_destroy` and `cnd_destroy`?


Repository:
  rCXX libc++

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D64378/new/

https://reviews.llvm.org/D64378