[libcxx-commits] [PATCH] D64378: [libcxx] Use C11 thread API on Fuchsia

[Eric Fiselier via Phabricator via libcxx-commits]

EricWF added a comment.

If this is using the C11 threading API and isn't Fuchsia specific, then would the macro name reflect that?
i.e. `_LIBCPP_HAS_THREAD_API_C11`?



================
Comment at: libcxx/include/__threading_support:31
+#elif defined(_LIBCPP_HAS_THREAD_API_FUCHSIA)
+# define _ALL_SOURCE 1
+# include <threads.h>
----------------
jfb wrote:
> What does this do? Docs say "Enable extensions for AIX 3, and for Interix."
What happens when `threads.h` is included before any libc++ headers?
We might have to lift this define into the compiler, like we've had to do with `_GNU_SOURCE`.


Repository:
  rCXX libc++

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D64378/new/

https://reviews.llvm.org/D64378