[libcxx-commits] [PATCH] D58332: Erase-Like Algorithms Should Return size_type (P0646R1)

Marshall Clow via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Fri Jul 5 22:26:50 PDT 2019


mclow.lists added a comment.

In D58332#1571535 <https://reviews.llvm.org/D58332#1571535>, @miyuki wrote:

> Shouldn't the type change be guarded with a conditional compilation construct? I could write
>
>   std::list<int> l
>   assert(typeid(void) == typeid(l.unique()));
>
>
> and expect this assertion to pass when compiling with, say, -std=c++98.


Yes, it should. I'll fix it. Thanks!


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58332/new/

https://reviews.llvm.org/D58332





More information about the libcxx-commits mailing list