[libcxx-commits] [PATCH] D64105: libc++: add _LIBCPP_HAS_NO_LONG_DOUBLE

[Marshall Clow via Phabricator via libcxx-commits]

mclow.lists added a comment.

This patch seems incomplete to me. There's stuff in `<type_traits>` like `is_floating_point`, etc.



================
Comment at: libcxx/include/cmath:445
 using ::nextafterf;
+#ifndef _LIBCXX_HAS_NO_LONG_DOUBLE
 using ::nexttoward;
----------------
These seem wrong to me. `nexttoward` takes a double, and `nexttowardf` takes a float.



================
Comment at: libcxx/include/cstdlib:114
+#ifndef _LIBCPP_HAS_NO_LONG_DOUBLE
 using ::strtold;
+#endif // _LIBCPP_HAS_NO_LONG_DOUBLE
----------------
There's a lot more work to be done if you want to remove `strtold`. 
Check out:
  - src/string.cpp
  - include/stdlib.h
  - several other places - do a search



================
Comment at: libcxx/include/locale:180
 
+#include <features.h>
 #include <__config>
----------------
Where did **this** come from?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D64105/new/

https://reviews.llvm.org/D64105