[libcxx-commits] [PATCH] D64105: libc++: add _LIBCPP_HAS_NO_LONG_DOUBLE

[Dionna Amalie Glaze via Phabricator via libcxx-commits]

deeglaze marked an inline comment as done.
deeglaze added inline comments.


================
Comment at: libcxx/include/math.h:789
 
+#if !(defined(_AIX) || defined(__sun__) || defined(__ASYLO__))
 inline _LIBCPP_INLINE_VISIBILITY long double
----------------
jfb wrote:
> These seem unfortunate. Can you look at the history to see why there's no feature macro that explains with?
It's not a uniform feature for Sun and AIX, as you can see further down for declarations like asinh. The sun support came 4 years ago in fbbfd092 for cmath, since math.h split from cmath after that. The AIX support was 6 years ago in 5d1a701, which seems slightly entangled with Microsoft's C runtime (_LIBCPP_MSVCRT). I'm not familiar enough with this codebase to suggest a feature strategy to overcome these unexpectedly non-uniform distinctions.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D64105/new/

https://reviews.llvm.org/D64105