[libcxx-commits] [PATCH] D56913: decoupling Freestanding atomic<T> from libatomic.a

JF Bastien via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Thu Jan 31 10:55:14 PST 2019


jfb added a comment.

Should all these macros be in `__config`?



================
Comment at: libcxx/include/atomic:911
+  _Tp __a_value;
+  mutable _Atomic_s(int, _Sco) __a_lock;
+
----------------
Can we make the lock `uint8_t` or something small for platforms where we have operations for it? Or could it rely on something like wg21.link/p1135r3 and use `atomic_flag`?


================
Comment at: libcxx/include/atomic:1265
     _LIBCPP_INLINE_VISIBILITY
-    atomic() _NOEXCEPT _LIBCPP_DEFAULT
+#ifndef _LIBCPP_CXX03_LANG
+    atomic() _NOEXCEPT = default;
----------------
Do we support `atomic` in C++03 mode?


Repository:
  rCXX libc++

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D56913/new/

https://reviews.llvm.org/D56913





More information about the libcxx-commits mailing list