[libcxx-commits] [PATCH] D57455: [libunwind] Provide inline placement new definition

[Petr Hosek via Phabricator via libcxx-commits]

phosek added a comment.

In D57455#1377727 <https://reviews.llvm.org/D57455#1377727>, @mclow.lists wrote:

> Turns out the placement versions of new are not replaceable, so what I said about UB is just wrong.
>
> However, In [new.delete.placement]/3, it says: These functions are reserved, a C++ program may not define functions that displace the versions in the Standard C++ library (17.6.4).


That shouldn't be a problem for shared library, for static library it might be it compiler decides not to inline it. Would it be better to use `__attribute__((__always_inline__))` to enforce that?


Repository:
  rUNW libunwind

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57455/new/

https://reviews.llvm.org/D57455