[libcxx-commits] [PATCH] D57330: Adjust documentation for git migration.

[James Y Knight via Phabricator via libcxx-commits]

jyknight marked 8 inline comments as done.
jyknight added a comment.

In D57330#1375096 <https://reviews.llvm.org/D57330#1375096>, @labath wrote:

> I am not sure we should be recommending to people to place the build folder under the llvm-project checkout. Is that how people use the monorepo build nowadays? This is not an full out-of-source build, since the build folder is still a subfolder of the repo root (and without a .gitignore file containing the right build folder name, git will complain about untracked files in the repository)...


Well, it's certainly how I do it. I find it the least confusing, because then I don't get mixed up as to which source tree a given build directory belongs to (or directories, as I may also have build-release, build-debug, etc).



================
Comment at: libcxx/docs/BuildingLibcxx.rst:57
   $ cd where-you-want-libcxx-to-live
-  $ # Check out llvm, libc++ and libc++abi.
-  $ ``svn co http://llvm.org/svn/llvm-project/llvm/trunk llvm``
-  $ ``svn co http://llvm.org/svn/llvm-project/libcxx/trunk libcxx``
-  $ ``svn co http://llvm.org/svn/llvm-project/libcxxabi/trunk libcxxabi``
+  $ # Check out the sources (includes everything, but we'll only use libcxx)
+  $ ``git clone https://github.com/llvm/llvm-project.git``
----------------
mehdi_amini wrote:
> Wonder if it is worth mentioning somewhere how to sparse-checkout?
Yes, I think it likely is worth mentioning that somewhere in the future -- but I'd rather not recommend it yet. There's two things that will impact that:

1. We'll need to decide where we plan to keep shared infrastructure (e.g. cmake macros etc) used by multiple subprojects within the repository.
2. It seems as though git is actually gaining new support for this kind of thing now, might be worth letting that mature a little bit.


================
Comment at: libcxxabi/www/index.html:86
   <li><code>mkdir build && cd build</code></li>
-  <li><code>cmake .. # on linux you may need to prefix with CC=clang CXX=clang++</code></li>
+  <li><code>cmake -DLLVM_ENABLE_PROJECTS=libcxxabi ../llvm # on linux you may need to prefix with CC=clang CXX=clang++</code></li>
   <li><code>make</code></li>
----------------
labath wrote:
> mehdi_amini wrote:
> > Do you now if prefixing with CC is equivalent to -DCMAKE_C_COMPILER?
> It usually is, but it can differ once you start using cache and toolchain files. In any case, using -DCMAKE_C(XX)_COMPILER is the preferred way to do things in cmake.
Changed to specify the cmake arguments.


================
Comment at: lld/docs/getting_started.rst:71
+     $ cd llvm-project/build (out of source build required)
+     $ cmake -G "Visual Studio 11" ../llvm
 
----------------
mehdi_amini wrote:
> Missing -DLLVM_ENABLE_PROJECTS=lld here I believe
Yep fixed.


================
Comment at: lldb/packages/Python/lldbsuite/test/functionalities/command_source/TestCommandSource.py:4
-
-See also http://llvm.org/viewvc/llvm-project?view=rev&revision=109673.
 """
----------------
smeenai wrote:
> Would you want to link to the corresponding GitHub commit?
After viewing said commit, I felt it wasn't actually useful to visit to understand this file, which is why I removed the link.


================
Comment at: lldb/packages/Python/lldbsuite/test/lang/objc/objc-optimized/TestObjcOptimized.py:4
 
-http://llvm.org/viewvc/llvm-project?rev=126973&view=rev
 Fixed a bug in the expression parser where the 'this'
----------------
smeenai wrote:
> Same here.
Felt the same in this case.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57330/new/

https://reviews.llvm.org/D57330