[libcxx-commits] [PATCH] D56699: [libc++] Update lit test configuration

Petr Hosek via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Tue Jan 29 00:10:20 PST 2019


phosek added inline comments.


================
Comment at: libcxx/test/lit.site.cfg.in:19
 config.host_triple              = "@LLVM_HOST_TRIPLE@"
-config.target_triple            = "@TARGET_TRIPLE@"
-config.use_target               = len("@LIBCXX_TARGET_TRIPLE@") > 0
-config.sysroot                  = "@LIBCXX_SYSROOT@"
+config.target_triple            = "@TARGET_TRIPLE@" or "@CMAKE_CXX_TARGET_TRIPLE@"
+config.use_target               = bool(config.target_triple)
----------------
ldionne wrote:
> Is `CMAKE_CXX_TARGET_TRIPLE` a thing? Where is it documented? I can't find it as of CMake 3.13.3
Thanks for checking, this should be `CMAKE_CXX_COMPILER_TARGET`.


Repository:
  rCXX libc++

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D56699/new/

https://reviews.llvm.org/D56699





More information about the libcxx-commits mailing list