[libcxx-commits] [libcxx] r352341 - [CMake] Use __libc_start_main rather than fopen when checking for C library
Petr Hosek via libcxx-commits
libcxx-commits at lists.llvm.org
Sun Jan 27 20:12:54 PST 2019
Author: phosek
Date: Sun Jan 27 20:12:54 2019
New Revision: 352341
URL: http://llvm.org/viewvc/llvm-project?rev=352341&view=rev
Log:
[CMake] Use __libc_start_main rather than fopen when checking for C library
The check_library_exists CMake uses a custom symbol definition. This
is a problem when checking for C library symbols because Clang
recognizes many of them as builtins, and returns the
-Wbuiltin-requires-header (or -Wincompatible-library-redeclaration)
error. When building with -Werror which is the default, this causes
the check_library_exists check fail making the build think that C
library isn't available.
To avoid this issue, we should use a symbol that isn't recognized by
Clang and wouldn't cause the same issue. __libc_start_main seems like
reasonable choice that fits the bill.
Differential Revision: https://reviews.llvm.org/D57142
Modified:
libcxx/trunk/cmake/config-ix.cmake
Modified: libcxx/trunk/cmake/config-ix.cmake
URL: http://llvm.org/viewvc/llvm-project/libcxx/trunk/cmake/config-ix.cmake?rev=352341&r1=352340&r2=352341&view=diff
==============================================================================
--- libcxx/trunk/cmake/config-ix.cmake (original)
+++ libcxx/trunk/cmake/config-ix.cmake Sun Jan 27 20:12:54 2019
@@ -7,7 +7,7 @@ if(WIN32 AND NOT MINGW)
# let the default linking take care of that.
set(LIBCXX_HAS_C_LIB NO)
else()
- check_library_exists(c fopen "" LIBCXX_HAS_C_LIB)
+ check_library_exists(c __libc_start_main "" LIBCXX_HAS_C_LIB)
endif()
if (NOT LIBCXX_USE_COMPILER_RT)
More information about the libcxx-commits
mailing list