[PATCH] D56997: Fix implementation of P0966 - string::reserve Should Not Shrink

[Andrew Luo via Phabricator]

andrewluo added a comment.

You are right, it is not guaranteed per the standard, although it has worked before (at least on MSVC).  Unfortunately, I've seen many instances of code that relies on this implementation-specific behavior (particularly older code that uses bind instead of lambdas).

Anyways though, if you think we should go ahead and split the functions for all dialects anyways (C++2a as well as pre-C++2a) then I can revert that part of the changes...


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D56997/new/

https://reviews.llvm.org/D56997