[PATCH] D56981: [libunwind] Enable LLVM_ENABLE_WARNINGS when building standalone out of tree

[Martin Storsjö via Phabricator]

mstorsjo created this revision.
mstorsjo added reviewers: mclow.lists, EricWF, ldionne.
Herald added subscribers: libcxx-commits, mgorny.

When built within the llvm runtimes directory, the runtimes CMakeLists.txt adds the same.

This would have helped catch the issue behind D56905 <https://reviews.llvm.org/D56905> over a year ago.


Repository:
  rUNW libunwind

https://reviews.llvm.org/D56981

Files:
  CMakeLists.txt


Index: CMakeLists.txt
===================================================================
--- CMakeLists.txt
+++ CMakeLists.txt
@@ -73,6 +73,8 @@
   endif()
 
   if (EXISTS ${LLVM_CMAKE_PATH})
+    # Enable warnings, otherwise -w gets added to the cflags by HandleLLVMOptions.
+    set(LLVM_ENABLE_WARNINGS ON)
     list(APPEND CMAKE_MODULE_PATH "${LLVM_CMAKE_PATH}")
     include("${LLVM_CMAKE_PATH}/AddLLVM.cmake")
     include("${LLVM_CMAKE_PATH}/HandleLLVMOptions.cmake")


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D56981.182709.patch
Type: text/x-patch
Size: 476 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/libcxx-commits/attachments/20190120/50b2ab19/attachment.bin>