[PATCH] D56979: [libcxxabi] Enable LLVM_ENABLE_WARNINGS when building standalone out of tree

Martin Storsjö via Phabricator reviews at reviews.llvm.org
Sun Jan 20 13:17:23 PST 2019


mstorsjo created this revision.
mstorsjo added reviewers: mclow.lists, EricWF, ldionne.
Herald added a subscriber: mgorny.

When built within the llvm runtimes directory, the runtimes CMakeLists.txt adds the same.


Repository:
  rCXXA libc++abi

https://reviews.llvm.org/D56979

Files:
  cmake/Modules/HandleOutOfTreeLLVM.cmake


Index: cmake/Modules/HandleOutOfTreeLLVM.cmake
===================================================================
--- cmake/Modules/HandleOutOfTreeLLVM.cmake
+++ cmake/Modules/HandleOutOfTreeLLVM.cmake
@@ -93,6 +93,8 @@
     endif()
   endif()
   if (LLVM_FOUND)
+    # Enable warnings, otherwise -w gets added to the cflags by HandleLLVMOptions.
+    set(LLVM_ENABLE_WARNINGS ON)
     include(AddLLVM OPTIONAL)
     include(HandleLLVMOptions OPTIONAL)
   endif()


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D56979.182707.patch
Type: text/x-patch
Size: 465 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/libcxx-commits/attachments/20190120/fe319b3e/attachment.bin>


More information about the libcxx-commits mailing list