[PATCH] D56139: [pstl] Fix compile errors when PARALLEL_POLICIES is disabled

Thomas Rodgers via Phabricator reviews at reviews.llvm.org
Thu Jan 17 10:44:44 PST 2019


rodgert requested changes to this revision.
rodgert added a comment.
This revision now requires changes to proceed.

See inline notes on __PSTL_USE_PAR_POLICIES #ifdefs



================
Comment at: include/pstl/internal/algorithm_impl.h:2432-2439
 template <class _ExecutionPolicy, class _OutputIterator, class _Size, class _Tp, class _IsVector>
 _OutputIterator
 pattern_fill_n(_ExecutionPolicy&& __exec, _OutputIterator __first, _Size __count, const _Tp& __value,
                /*is_parallel=*/std::true_type, _IsVector __is_vector)
 {
     return internal::pattern_fill(std::forward<_ExecutionPolicy>(__exec), __first, __first + __count, __value,
                                   std::true_type(), __is_vector);
----------------
Shouldn't this definition also be protected by #ifdef __PSTL_USE_PAR_POLICIES?


Repository:
  rPSTL pstl

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D56139/new/

https://reviews.llvm.org/D56139





More information about the libcxx-commits mailing list