[PATCH] D55840: P0722R3: Implement library support for destroying delete
Marshall Clow via Phabricator
reviews at reviews.llvm.org
Fri Jan 11 11:26:22 PST 2019
mclow.lists added inline comments.
================
Comment at: include/new:169
+
+struct destroying_delete_t {
+ explicit destroying_delete_t() = default;
----------------
ckennelly wrote:
> ldionne wrote:
> > Please guard with > C++17. We should not enable features in older standards unless we have a compelling reason to.
> If there's compiler support (we're checking _impl), would it be reasonable to provide it with C++17 as well?
Not reasonable, no.
I did this one, for something that I thought was a slam-dunk (`string_view` in pre-c++17) and it has been nothing but a series of small annoyances.
Repository:
rCXX libc++
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D55840/new/
https://reviews.llvm.org/D55840
More information about the libcxx-commits
mailing list