[PATCH] D56519: Filesystem tests: fix fs.op.relative

JF Bastien via Phabricator reviews at reviews.llvm.org
Wed Jan 9 16:07:12 PST 2019


jfb added a comment.

In D56519#1352024 <https://reviews.llvm.org/D56519#1352024>, @jfb wrote:

> In D56519#1352022 <https://reviews.llvm.org/D56519#1352022>, @EricWF wrote:
>
> > So there is certainly a bug here. Thanks for fixing it.
> >
> > The test was written in this weird way to aid in debugging test failures. Without the additional output it's not clear what test case failed or why.
>
>
> I can just split up each entry in `TestCases` into its own `TEST_CASE` if you want. Trivial :)


Alright I was waiting for a build, so I just did a few regular expressions and voila!


Repository:
  rCXX libc++

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D56519/new/

https://reviews.llvm.org/D56519





More information about the libcxx-commits mailing list