[PATCH] D56498: [libcxx] Fix order checking in some more unordered_multimap tests.

Andrey Maksimov via Phabricator reviews at reviews.llvm.org
Wed Jan 9 09:20:35 PST 2019


amakc11 created this revision.
Herald added a reviewer: EricWF.
Herald added subscribers: libcxx-commits, ldionne.

Some tests assume that iteration through an unordered multimap elements will return them in the same order as at the container creation. This assumption is not true since the container is **unordered**, so that no specific order of elements is ever guaranteed for such container. This patch is a continuation of D54838 <https://reviews.llvm.org/D54838> and introduces checks verifying that any iteration will return elements exactly from a set of valid values and without repetition, but in no particular order.


Repository:
  rCXX libc++

https://reviews.llvm.org/D56498

Files:
  test/std/containers/unord/unord.multimap/unord.multimap.cnstr/assign_copy.pass.cpp
  test/std/containers/unord/unord.multimap/unord.multimap.cnstr/assign_init.pass.cpp
  test/std/containers/unord/unord.multimap/unord.multimap.cnstr/assign_move.pass.cpp
  test/std/containers/unord/unord.multimap/unord.multimap.cnstr/copy.pass.cpp
  test/std/containers/unord/unord.multimap/unord.multimap.cnstr/copy_alloc.pass.cpp
  test/std/containers/unord/unord.multimap/unord.multimap.cnstr/init.pass.cpp
  test/std/containers/unord/unord.multimap/unord.multimap.cnstr/init_size.pass.cpp
  test/std/containers/unord/unord.multimap/unord.multimap.cnstr/init_size_hash.pass.cpp
  test/std/containers/unord/unord.multimap/unord.multimap.cnstr/init_size_hash_equal.pass.cpp
  test/std/containers/unord/unord.multimap/unord.multimap.cnstr/init_size_hash_equal_allocator.pass.cpp
  test/std/containers/unord/unord.multimap/unord.multimap.cnstr/move.pass.cpp
  test/std/containers/unord/unord.multimap/unord.multimap.cnstr/move_alloc.pass.cpp
  test/std/containers/unord/unord.multimap/unord.multimap.cnstr/range.pass.cpp
  test/std/containers/unord/unord.multimap/unord.multimap.cnstr/range_size.pass.cpp
  test/std/containers/unord/unord.multimap/unord.multimap.cnstr/range_size_hash.pass.cpp
  test/std/containers/unord/unord.multimap/unord.multimap.cnstr/range_size_hash_equal.pass.cpp
  test/std/containers/unord/unord.multimap/unord.multimap.cnstr/range_size_hash_equal_allocator.pass.cpp
  test/std/containers/unord/unord.multimap/unord.multimap.modifiers/erase_const_iter.pass.cpp
  test/std/containers/unord/unord.multimap/unord.multimap.modifiers/erase_key.pass.cpp
  test/std/containers/unord/unord.multimap/unord.multimap.modifiers/erase_range.pass.cpp
  test/std/containers/unord/unord.multimap/unord.multimap.modifiers/insert_init.pass.cpp
  test/std/containers/unord/unord.multimap/unord.multimap.modifiers/insert_range.pass.cpp
  test/std/containers/unord/unord.multimap/unord.multimap.swap/swap_non_member.pass.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D56498.180860.patch
Type: text/x-patch
Size: 105870 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/libcxx-commits/attachments/20190109/a67bd178/attachment-0001.bin>


More information about the libcxx-commits mailing list